-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All chapters: organizational cleanup #473
Conversation
Opening this for review from all. @kbjarkefur - I noticed that even though I am now able to compile the manuscript I still am not getting the commit hash: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Ben!
Minor comments added inline :)
Co-authored-by: Luiza Andrade <[email protected]>
Co-authored-by: Luiza Andrade <[email protected]>
Co-authored-by: Luiza Andrade <[email protected]>
Co-authored-by: Luiza Andrade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but we still need to address Arianna's comments regarding the intro:
-
Comment: "this is four author guide that gives no credit to the work of everybody who contributed to DIME and DIME Analytics. I am worried about this. The background should be DIME and why we established DIME Analytics and what DIME Analytics produced as a result of working on DIME projects... It will have to explain what DIME does (either without copying and pasting or by using quotes and referring to the original documents). You need to include stats on the size of our data efforts, the size of our FC and RA pools, and how this motivated the establishment of DIME analytics and how DIME analytics capitalized on the knowledge generated in the process of doing research and field work. "
-
revise the DIME overview paragraph to reflect the above: cite the annual report, make sure that numbers mentioned in this paragraph align with what's there, and that the text is not an exact copy-paste. also the IDEA handbook chapter might be useful to cite. Link to the text is here, the chapter is forthcoming but citeable: https://worldbankgroup-my.sharepoint.com/:w:/g/personal/mjones5_worldbank_org/EWtukZMQT9JNhS9ykWniNIoB5GN1kEt84IqNQJ3_m70gkA?e=dG5FZr.
-
add more to the paragraph describing DIME Analytics. the IDEA handbook chapter is a possible source for that. Arianna's comment "The intro should also give an overview of the transformation in expectations from the development economics profession and how this created a different institutional framework for us to work in and contribute to. Separating what was done by others e.g. registries, and what our contribution has been, e.g. proper protocols for reproducibility, is very important. None of our contribution comes out."
-
still need to address Arianna's comment: "The introduction should have a clear motivation of why data and not only research design is important for generating credible evidence. Here you need to make reference to actual research on the perils of poor data on research conclusions. "
-
the section on good code seems a little out of place with the flow of the rest of the introduction. i wonder if it still belongs here? i could also see it perhaps moving to chapter 2. but i don't feel strongly about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! just a few more comments in line, mostly minor
chapters/0-introduction.tex
Outdated
While is often \textit{possible} to perform nearly all the relevant tasks | ||
through an interactive user interface or even through software such as Excel, | ||
this practice is strongly advised against. | ||
In the context of statistical analysis, this approach is widely accepted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
widely accepted? increasingly perhaps, with pressure from journals ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this is not clear, it's meant to say that "everyone agrees analysis work should be coded" in contrast to, say, data work. does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, that does make sense. it wasn't clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Maria <[email protected]>
Co-authored-by: Maria <[email protected]>
Co-authored-by: Maria <[email protected]>
Co-authored-by: Maria <[email protected]>
Co-authored-by: Maria <[email protected]>
Co-authored-by: Maria <[email protected]>
…ata-handbook into bbd-org-cleanup
Co-authored-by: Kristoffer Bjärkefur <[email protected]>
Co-authored-by: Kristoffer Bjärkefur <[email protected]>
This PR will include:
Close the following: