Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch 3 #490

Merged
merged 41 commits into from
Aug 26, 2020
Merged

Ch 3 #490

merged 41 commits into from
Aug 26, 2020

Conversation

kbjarkefur
Copy link
Contributor

This PR includes a rewrite of Ch3 mainly based on 2 new addtions:

  • DIME Data Plan template with the three components - Data Linkage Table, Master Datasets, Data Flow Charts
  • The definition of "research variables" and "measurement variables"

@kbjarkefur
Copy link
Contributor Author

This is now ready for review. There is some stuff in there that we have discussed in meetings but not discussed after seen written. I am looking forward to see what you have to say.

chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
Co-authored-by: Benjamin Daniels <[email protected]>
@kbjarkefur kbjarkefur mentioned this pull request Aug 19, 2020
Copy link
Contributor

@mariaruth mariaruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments -- i'm worried the review feature will bug so submitting now and will finish reviewing the rest of the chapter after.

chapters/3-measurement.tex Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
chapters/3-measurement.tex Outdated Show resolved Hide resolved
Copy link
Contributor

@mariaruth mariaruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having some trouble with the review function, moving to single comments

kbjarkefur and others added 2 commits August 26, 2020 10:57
@mariaruth
Copy link
Contributor

all set from my side, @luizaandrade a few inputs from you needed before merging

Co-authored-by: Maria <[email protected]>
@kbjarkefur kbjarkefur merged commit 7b9431b into mj-review Aug 26, 2020
@kbjarkefur kbjarkefur deleted the ch-3 branch August 26, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants