-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ch 3 #490
Ch 3 #490
Conversation
This is now ready for review. There is some stuff in there that we have discussed in meetings but not discussed after seen written. I am looking forward to see what you have to say. |
Co-authored-by: Benjamin Daniels <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch of comments -- i'm worried the review feature will bug so submitting now and will finish reviewing the rest of the chapter after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having some trouble with the review function, moving to single comments
Co-authored-by: Benjamin Daniels <[email protected]>
all set from my side, @luizaandrade a few inputs from you needed before merging |
Co-authored-by: Maria <[email protected]>
This PR includes a rewrite of Ch3 mainly based on 2 new addtions: