Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versions: diamond: read power board & front unit versions #24

Merged
merged 1 commit into from
May 22, 2024

Conversation

fouge
Copy link
Collaborator

@fouge fouge commented May 16, 2024

uses io expander on the boards

fixes O-2189

@fouge fouge requested a review from moritz-diller May 16, 2024 08:19
@fouge fouge force-pushed the fouge/front-unit-power-board-versions branch from 3f9d66f to 0c2090c Compare May 16, 2024 08:20
Copy link
Contributor

@moritz-diller moritz-diller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to read the version via the port expander only once and then save it in a static variable. See the logic for the Mainboard hardware version. Reading the version via the port expander is quite time expensive since it is accessed via I2C.

Additionally, I would not create new enums (front_unit_version_e and power_board_version_e), but add new fields to orb-messages. We should transmit the versions to orb-core anyway. This information should be logged to Datadog and we might need the Front Unit version for adjusting the RGB LED colors if we see mismatches between the different LED types.

@fouge
Copy link
Collaborator Author

fouge commented May 16, 2024

@moritz-diller let's keep it simple for now:
B3 are going to be mounted with v6.2B by default so we should consider it the default plan. If we start to mount different boards on B3, then we might want to report the specific boards versions to the Jetson.

@fouge fouge force-pushed the fouge/front-unit-power-board-versions branch 2 times, most recently from 752870c to 6bd5707 Compare May 16, 2024 08:57
@fouge fouge requested a review from moritz-diller May 16, 2024 08:58
@moritz-diller
Copy link
Contributor

@moritz-diller let's keep it simple for now: B3 are going to be mounted with v6.2B by default so we should consider it the default plan. If we start to mount different boards on B3, then we might want to report the specific boards versions to the Jetson.

In the long term the variant v6.2.A shall be assembled. We created v6.2.B only because we could not source the Wuerth RGB LEDs fast enough. And we should track the different versions on Datadog. Additionally the chances are quite high, that there will be further hardware changes in the future, so I recommend to create the protobuf defintion right now.

@fouge
Copy link
Collaborator Author

fouge commented May 16, 2024

ah okay, I didn't understand that.
I will have to postpone to next week 👍

@fouge fouge marked this pull request as draft May 16, 2024 09:05
@fouge fouge removed the request for review from moritz-diller May 16, 2024 09:05
@fouge fouge marked this pull request as ready for review May 22, 2024 10:05
@fouge fouge force-pushed the fouge/front-unit-power-board-versions branch from fececde to 3d7e06a Compare May 22, 2024 16:38
@fouge fouge merged commit bccddec into main May 22, 2024
5 checks passed
@fouge fouge deleted the fouge/front-unit-power-board-versions branch May 22, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants