Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check pull-request title #3

Merged
merged 1 commit into from
Mar 20, 2024
Merged

ci: check pull-request title #3

merged 1 commit into from
Mar 20, 2024

Conversation

fouge
Copy link
Collaborator

@fouge fouge commented Mar 19, 2024

signed commit cannot be rebased onto main
so rebasing when merging PR has been disabled
in favor of the squash commit.
Thus we want the PR title to match the expected
format:
"[area]: [desc]"
and max 72 characters"

@fouge fouge force-pushed the fouge/pr-compliance branch from 06c897e to 15dcbcc Compare March 19, 2024 13:37
@fouge fouge changed the title ci: check pr title ci: check pull-request title Mar 19, 2024
@fouge fouge force-pushed the fouge/pr-compliance branch 2 times, most recently from 44f51a1 to e250ea4 Compare March 19, 2024 13:49
@fouge fouge changed the base branch from main to fouge/orb-messages March 19, 2024 13:49
@fouge fouge force-pushed the fouge/pr-compliance branch from e250ea4 to ede7cbd Compare March 19, 2024 13:52
@fouge fouge changed the title ci: check pull-request title ci: check pull-request title & body Mar 19, 2024
@fouge fouge force-pushed the fouge/pr-compliance branch from ede7cbd to 3dc9073 Compare March 19, 2024 13:56
@fouge fouge changed the title ci: check pull-request title & body ci: check pull-request title Mar 19, 2024
@fouge fouge requested a review from TheButlah March 19, 2024 13:57
@fouge fouge marked this pull request as draft March 19, 2024 14:01
@fouge
Copy link
Collaborator Author

fouge commented Mar 19, 2024

let's merge #2 first

@fouge fouge force-pushed the fouge/pr-compliance branch from 3dc9073 to 4aadaba Compare March 19, 2024 14:18
Base automatically changed from fouge/orb-messages to main March 20, 2024 11:47
@fouge fouge force-pushed the fouge/pr-compliance branch from 4aadaba to cb33f5f Compare March 20, 2024 11:49
signed commit cannot be rebased onto main
so rebasing when merging PR has been disabled
in favor of the squash commit.
Thus we want the PR title to match the expected
format:
"[area]: [desc]"
and max 72 characters"

Signed-off-by: Cyril Fougeray <[email protected]>
@fouge fouge force-pushed the fouge/pr-compliance branch from cb33f5f to 8bb2841 Compare March 20, 2024 11:50
@fouge fouge marked this pull request as ready for review March 20, 2024 11:51
@fouge fouge requested a review from eth44 March 20, 2024 11:51
@fouge fouge enabled auto-merge (squash) March 20, 2024 11:52
Copy link
Contributor

@eth44 eth44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good against command injection, looks good against regex DoS.

@fouge fouge merged commit e1b6fce into main Mar 20, 2024
5 checks passed
@fouge fouge deleted the fouge/pr-compliance branch March 20, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants