feat(fleet-cmdr): FM-210 initial implementation of fleet-cmdr daemon #363

paulquinn00 · 2025-02-03T20:38:40Z

Fleet Commander (fleet-cmdr) is a daemon which permanently connects to the Orb Relay to receive job commands from the Orb Fleet Backend. This initial implementation of the fleet-cmdr daemon includes the following changes:

fleet command basic implementation
integration of relay-client and basic command parsing
endpoint updates to include relay urls

Michael-Preibisch

Generally LGTM. I was nit-picky with comments. I will leave it up to orb-software experts to give the final stamp

endpoints/src/v1.rs

fleet-cmdr/src/handlers/cmd_orb_details.rs

fleet-cmdr/src/handlers/cmd_reboot.rs

fleet-cmdr/src/handlers/mod.rs

fleet-cmdr/debian/fleet-cmdr.worldcoin-fleet-cmdr.service

fleet-cmdr/src/handlers/cmd_reboot.rs

fleet-cmdr/src/main.rs

fleet-cmdr/debian/fleet-cmdr.worldcoin-fleet-cmdr.service

fleet-cmdr/src/settings.rs

TheButlah

review wip, will discuss more in our meeting. Overall very good.

fleet-cmdr/src/handlers/cmd_reboot.rs

endpoints/src/v1.rs

fleet-cmdr/debian/fleet-cmdr.worldcoin-fleet-cmdr.service

fleet-cmdr/src/main.rs

fleet-cmdr/src/orb_info.rs

fleet-cmdr/src/settings.rs

fleet-cmdr/src/handlers/mod.rs

fleet-cmdr/src/handlers/cmd_orb_details.rs

oldgalileo · 2025-02-04T18:32:33Z

fleet-cmdr/src/handlers/cmd_orb_details.rs

+        let _request = OrbDetailsRequest::decode(command.payload.as_slice()).unwrap();
+        // TODO(paulquinn00): Consult with @oldgalileo and @sfikastheo to determine where to get this info from.
+        let response = OrbDetailsResponse {
+            orb_id: "".to_string(),


Should usually be fetched through an environment variable which is populated with the /usr/local/bin/orb-id command.

oldgalileo · 2025-02-04T18:32:42Z

fleet-cmdr/src/handlers/cmd_orb_details.rs

+        // TODO(paulquinn00): Consult with @oldgalileo and @sfikastheo to determine where to get this info from.
+        let response = OrbDetailsResponse {
+            orb_id: "".to_string(),
+            orb_name: "".to_string(),


/usr/persistent/orb-name

oldgalileo · 2025-02-04T18:32:50Z

fleet-cmdr/src/handlers/cmd_orb_details.rs

+        let response = OrbDetailsResponse {
+            orb_id: "".to_string(),
+            orb_name: "".to_string(),
+            jabil_id: "".to_string(),


/usr/persistent/jabil-id

oldgalileo · 2025-02-04T18:40:33Z

fleet-cmdr/src/handlers/cmd_orb_details.rs

+            orb_id: "".to_string(),
+            orb_name: "".to_string(),
+            jabil_id: "".to_string(),
+            hardware_version: "".to_string(),


Get this information from the MCUs or over DBus

can't we just use mcu-util?

Yes, that's fine too. @TheButlah we should probably honestly normalize the collection of all of this early-boot.

oldgalileo · 2025-02-04T18:40:41Z

fleet-cmdr/src/handlers/cmd_orb_details.rs

+            hardware_version: "".to_string(),
+            software_version: "".to_string(),
+            software_update_version: "".to_string(),
+            os_release_type: "".to_string(),


What does this mean?

oldgalileo · 2025-02-04T18:41:10Z

fleet-cmdr/src/handlers/cmd_orb_details.rs

+            software_version: "".to_string(),
+            software_update_version: "".to_string(),
+            os_release_type: "".to_string(),
+            active_slot: "".to_string(),


Environment variable filled in by orb-slot-ctrl, or through the orb-slot-ctrl library.

oldgalileo · 2025-02-04T18:41:35Z

fleet-cmdr/src/handlers/cmd_orb_details.rs

+            software_update_version: "".to_string(),
+            os_release_type: "".to_string(),
+            active_slot: "".to_string(),
+            uptime_seconds: 0,


When should the uptime be counted?

fleet-cmdr/src/handlers/cmd_orb_details.rs

fleet-cmdr/src/main.rs

TheButlah

approving, assuming that @paulquinn00 removes signal handlers and also reworks to get rid of the trait objects (probably using a match statement)

TheButlah · 2025-02-04T19:45:45Z

fleet-cmdr/src/handlers/cmd_orb_details.rs

+            orb_id: "".to_string(),
+            orb_name: "".to_string(),
+            jabil_id: "".to_string(),
+            hardware_version: "".to_string(),


can't we just use mcu-util?

TheButlah · 2025-02-04T19:48:47Z

fleet-cmdr/src/main.rs

+    let opts = ClientOpts::entity(EntityType::Orb)
+        .id(args.orb_id.clone().unwrap())
+        .endpoint(endpoints.clone())
+        .namespace(args.relay_namespace.clone().unwrap())


Suggested change

.namespace(args.relay_namespace.clone().unwrap())

.namespace(args.relay_namespace.clone().unwrap())

// TODO: FM-369

Co-authored-by: Ryan Butler <[email protected]>

TheButlah · 2025-02-04T22:37:13Z

fleet-cmdr/src/handlers/mod.rs

+        msg: &RecvMessage,
+    ) -> Result<(), OrbCommandError> {
+        let any = Any::decode(msg.payload.as_slice()).unwrap();
+        if any.type_url == OrbDetailsRequest::type_url() {


it works, although maybe this is better:

match any.type_url { u if u == OrbDetailsRequest::type_url() => /* ... */ , u if u == OrbRebootRequest::type_url() => /* .. */, }

TheButlah · 2025-02-04T22:39:37Z

Dismissing @oldgalileo's review as stale, since @paulquinn00 has agreed to implement the following subsequent PRs:

PR to add token refresh via dbus
PR to add the other orb info that @oldgalileo has listed out in his comments
Final cleanup PR to tie up any loose ends (packaging, robustness to failure, etc)

paul will address feedback in subsequent PRs

paulquinn00 requested review from vmenge, TheButlah, valff, matthewpaul and Michael-Preibisch February 3, 2025 20:38

Michael-Preibisch reviewed Feb 4, 2025

View reviewed changes

endpoints/src/v1.rs Show resolved Hide resolved

fleet-cmdr/src/handlers/cmd_orb_details.rs Outdated Show resolved Hide resolved

fleet-cmdr/src/handlers/cmd_reboot.rs Outdated Show resolved Hide resolved

fleet-cmdr/src/handlers/mod.rs Outdated Show resolved Hide resolved

alekseifedotov reviewed Feb 4, 2025

View reviewed changes

TheButlah requested changes Feb 4, 2025

View reviewed changes

paulquinn00 requested a review from TheButlah February 4, 2025 16:42

paulquinn00 force-pushed the FM-210-orb-fleet-cmdr branch from d5e19e7 to 1be49aa Compare February 4, 2025 16:58

paulquinn00 requested review from alekseifedotov, sfikastheo and Michael-Preibisch February 4, 2025 17:07

oldgalileo requested changes Feb 4, 2025

View reviewed changes

oldgalileo previously requested changes Feb 4, 2025

View reviewed changes

fleet-cmdr/src/main.rs Outdated Show resolved Hide resolved

TheButlah approved these changes Feb 4, 2025

View reviewed changes

paulquinn00 enabled auto-merge (squash) February 4, 2025 21:30

paulquinn00 disabled auto-merge February 4, 2025 21:31

paulquinn00 and others added 8 commits February 4, 2025 22:31

feat(fleet-cmdr): FM-210 initial implementation of fleet-cmdr daemon

a6022be

clippy, author

153d8e6

undid Backend::Local

6dfd63f

pr feedback

7aa4551

pr feedback

ab7e5e5

Update fleet-cmdr/src/handlers/cmd_orb_details.rs

1c8a1e7

Co-authored-by: Ryan Butler <[email protected]>

settings are redundant with args

181c442

removed signal handlers, async_trait

57dbb08

paulquinn00 force-pushed the FM-210-orb-fleet-cmdr branch from 8f6191f to 57dbb08 Compare February 4, 2025 21:31

paulquinn00 requested a review from oldgalileo February 4, 2025 21:36

TheButlah approved these changes Feb 4, 2025

View reviewed changes

TheButlah merged commit b78da83 into main Feb 4, 2025
14 checks passed

TheButlah deleted the FM-210-orb-fleet-cmdr branch February 4, 2025 22:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(fleet-cmdr): FM-210 initial implementation of fleet-cmdr daemon #363

feat(fleet-cmdr): FM-210 initial implementation of fleet-cmdr daemon #363

paulquinn00 commented Feb 3, 2025

Michael-Preibisch left a comment

TheButlah left a comment

oldgalileo Feb 4, 2025

oldgalileo Feb 4, 2025

oldgalileo Feb 4, 2025

oldgalileo Feb 4, 2025

TheButlah Feb 4, 2025

oldgalileo Feb 4, 2025

oldgalileo Feb 4, 2025

oldgalileo Feb 4, 2025

oldgalileo Feb 4, 2025

TheButlah left a comment

TheButlah Feb 4, 2025

TheButlah Feb 4, 2025

TheButlah Feb 4, 2025

TheButlah commented Feb 4, 2025

	.namespace(args.relay_namespace.clone().unwrap())
	.namespace(args.relay_namespace.clone().unwrap())
	// TODO: FM-369

feat(fleet-cmdr): FM-210 initial implementation of fleet-cmdr daemon #363

feat(fleet-cmdr): FM-210 initial implementation of fleet-cmdr daemon #363

Conversation

paulquinn00 commented Feb 3, 2025

Michael-Preibisch left a comment

Choose a reason for hiding this comment

TheButlah left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TheButlah left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TheButlah commented Feb 4, 2025