Use the new p2p.Run API #329

bruce-riley · 2024-06-26T16:02:17Z

This modifies the fly and other gossip listening tools to use the new p2p.Run API.

It also adds support for observation batches.

Finally, removes the hardcoded bootstrap parameters in favor of the ones defined in node/pkg/p2p/network_consts.go.

evan-gray

repeated the comments about the unused components just to keep track. overall the less code is great, mostly concerned about fly/main.go where there doesn't appear to be a way to weak the gossip params anymore.

fly/go.mod

fly/cmd/track_pyth/main.go

fly/cmd/track_gossip/main.go

fly/cmd/prom_gossip/main.go

fly/cmd/observation_stats/main.go

fly/cmd/historical_uptime/main.go

fly/cmd/heartbeats/main.go

fly/cmd/fly/main.go

evan-gray

nice. one small change please :)

fly/cmd/prom_gossip/main.go

fly/cmd/observation_stats/main.go

fly/cmd/heartbeats/main.go

fly/cmd/historical_uptime/main.go

fly/cmd/observation_stats/main.go

fly/cmd/prom_gossip/main.go

fly/cmd/track_gossip/main.go

fly/cmd/prom_gossip/main.go

bingyuyap

Just some questions that I'm unclear with, also commented on parts that can be removed like single observations and comments due to the batch observation addition

fly/cmd/track_gossip/main.go

fly/cmd/track_pyth/main.go

evan-gray force-pushed the use_new_p2p_run_api branch from 73aa410 to 2e94bba Compare July 1, 2024 12:57

bruce-riley force-pushed the use_new_p2p_run_api branch from 57dbf42 to 9e01236 Compare August 19, 2024 16:34

bruce-riley marked this pull request as ready for review August 19, 2024 17:34

bruce-riley marked this pull request as draft August 19, 2024 17:36

evan-gray reviewed Aug 20, 2024

View reviewed changes

bruce-riley force-pushed the use_new_p2p_run_api branch 3 times, most recently from eabbccc to f6a4db6 Compare August 21, 2024 14:46

bruce-riley marked this pull request as ready for review August 21, 2024 15:07

bruce-riley requested review from evan-gray, panoel and bingyuyap August 21, 2024 15:10

evan-gray requested changes Aug 21, 2024

View reviewed changes

fly/cmd/prom_gossip/main.go Outdated Show resolved Hide resolved

evan-gray reviewed Aug 21, 2024

View reviewed changes

fly/cmd/prom_gossip/main.go Outdated Show resolved Hide resolved

bruce-riley mentioned this pull request Aug 21, 2024

Support batch observations #322

Closed

bruce-riley requested a review from evan-gray August 21, 2024 16:45

panoel reviewed Aug 21, 2024

View reviewed changes

fly/cmd/observation_stats/main.go Outdated Show resolved Hide resolved

panoel reviewed Aug 21, 2024

View reviewed changes

fly/cmd/observation_stats/main.go Outdated Show resolved Hide resolved

panoel previously approved these changes Aug 21, 2024

View reviewed changes