Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed private modifiers conflicting with Typescript #12

Merged
merged 3 commits into from
Sep 29, 2024
Merged

fix: Fixed private modifiers conflicting with Typescript #12

merged 3 commits into from
Sep 29, 2024

Conversation

polvallverdu
Copy link
Contributor

Trying to use socketless on typescript gives the following errors:

Property 'POST' of exported class expression may not be private or protected.ts(4094)
Property 'baseUrl' of exported class expression may not be private or protected.ts(4094)
Property 'url' of exported class expression may not be private or protected.

@polvallverdu polvallverdu added the release canary Releases canary version label Sep 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

A new canary is available for testing. You can install this latest build in your project with:

pnpm add @socketless/[email protected]
pnpm add @socketless/[email protected]
pnpm add [email protected]

@github-actions github-actions bot removed the release canary Releases canary version label Sep 29, 2024
@polvallverdu polvallverdu marked this pull request as ready for review September 29, 2024 21:49
@polvallverdu polvallverdu added the release canary Releases canary version label Sep 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

A new canary is available for testing. You can install this latest build in your project with:

pnpm add @socketless/[email protected]
pnpm add @socketless/[email protected]
pnpm add [email protected]

@github-actions github-actions bot removed the release canary Releases canary version label Sep 29, 2024
@polvallverdu polvallverdu merged commit 0b5a190 into main Sep 29, 2024
@polvallverdu polvallverdu deleted the fix/ts-no-private-exported-members branch September 29, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@polvallverdu