Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categories view mode #1762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Categories view mode #1762

wants to merge 1 commit into from

Conversation

mihaijoldis
Copy link

Fixes display type for categories overwriting the Presentation settings when selecting Default as option

Fixes display type for categories overwriting the Presentation settings when selecting Default as option
@JustinSainton
Copy link
Member

Is there an issue on Github for this PR?

@JustinSainton
Copy link
Member

#1505 perhaps?

@mihaijoldis
Copy link
Author

Even after using the code change above SOME of the categories might have the display_type set in the meta table. To make sure the code change above will work correctly for existing categories that already have that in the DB i ran a sql query to remove all meta for existing categories that used the DEFAUL view mode:

DELETE FROM `wp_wpsc_meta` WHERE `meta_key` = 'display_type' AND `meta_value` = 'default'

@JustinSainton
Copy link
Member

Sounds like we need an upgrade routine here before we can merge.

@JustinSainton
Copy link
Member

Just remembered this PR existed :) A couple things, if we want to land #1505 in 4.0

  • rather than using esc_sql(), let's check against a filtered array, containing grid/list.
  • as mentioned, we'll need an upgrade routine.

@JustinSainton
Copy link
Member

Punting this to 4.1, pending the required changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants