Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVIF settings update #775

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Jan 5, 2024

Description

This PR is meant to introduce settings update for AVIF format images.

Fixes #773

Type of change

  • New feature (non-breaking change which adds functionality).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

@Miraeld Miraeld self-assigned this Jan 5, 2024
@Miraeld Miraeld changed the base branch from develop to feature/avif January 5, 2024 10:26
@Miraeld Miraeld force-pushed the enhancement/773-avif-settings-update branch 4 times, most recently from 084cc15 to ab3b2dc Compare January 11, 2024 14:20
@Miraeld Miraeld force-pushed the enhancement/773-avif-settings-update branch from ab3b2dc to ffcbe66 Compare January 12, 2024 04:00
@Miraeld Miraeld requested review from remyperona and a team January 12, 2024 04:01
@Miraeld Miraeld changed the title DRAFT: AVIF settings update AVIF settings update Jan 12, 2024
inc/functions/common.php Outdated Show resolved Hide resolved
inc/functions/admin-ui.php Outdated Show resolved Hide resolved
classes/Optimization/Process/AbstractProcess.php Outdated Show resolved Hide resolved
classes/Bulk/Bulk.php Outdated Show resolved Hide resolved
classes/Avif/Avif.php Outdated Show resolved Hide resolved
classes/Optimization/File.php Outdated Show resolved Hide resolved
@remyperona remyperona merged commit 0e8a3b1 into feature/avif Jan 19, 2024
1 check failed
@remyperona remyperona deleted the enhancement/773-avif-settings-update branch January 19, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AVIF support: settings update
4 participants