-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change methods name #785
Change methods name #785
Conversation
@@ -202,20 +202,20 @@ protected function optimize_missing_sizes( $media_id, $context ) { | |||
* @param string $context The context. | |||
* @return bool|WP_Error True if successfully launched. A \WP_Error instance on failure. | |||
*/ | |||
protected function generate_webp_versions( $media_id, $context ) { | |||
protected function generate_nextgen_versions( $media_id, $context ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protected function generate_next_gen_versions( $media_id, $context ) { |
@@ -27,8 +27,8 @@ class Imagify_Admin_Ajax_Post extends Imagify_Admin_Ajax_Post_Deprecated { | |||
'imagify_manual_optimize', | |||
'imagify_manual_reoptimize', | |||
'imagify_optimize_missing_sizes', | |||
'imagify_generate_webp_versions', | |||
'imagify_delete_webp_versions', | |||
'imagify_generate_nextgen_versions', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'imagify_generate_next_gen_versions', |
* | ||
* @since 1.7 | ||
* | ||
* @param object $item The current item. It must contain at least a $process property. | ||
*/ | ||
protected function generate_webp_versions_button( $item ) { | ||
protected function generate_nextgen_versions_button( $item ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protected function generate_next_gen_versions_button( $item ) { |
@@ -363,21 +363,21 @@ public function imagify_optimize_missing_sizes_callback() { | |||
* | |||
* @since 1.9 | |||
*/ | |||
public function imagify_generate_webp_versions_callback() { | |||
public function imagify_generate_nextgen_versions_callback() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public function imagify_generate_next_gen_versions_callback() { |
There is no need to re-assign it I think. |
This PR needs conflict fixed before moving forward |
While resolving the conflicts I noticed that the issue #779 was created based on develop branch and deature/avif branch has few things that aren't captured in the issue. |
Description
Changed methods name for media library view
Fixes #779
Type of change
Is the solution different from the one proposed during the grooming?
No
Please describe in this section if there is any change to the groomed solution, and why.
Checklists
Generic development checklist
Test summary