3.17 - Activation/Deactivation with the filters

[piotrbak]

Context
We need to have filters to enable/disable both OCI and LRC features

Acceptance Criteria

• When both features are enabled
  • We'll display the clearing buttons and clearing sections
  • We'll clear the data as specified in the Epic Card
• When one of the features is disabled and the second one is enabled
  • We'll display the clearing buttons and clearing sections
  • We'll clear the data as specified in the Epic Card
  • In both of the above points the data will be cleared for both features
• When both features are disabled
  • We'll not display the clearing buttons and clearing sections
  • We'll clear the data as specified in the Epic Card
  • In the above point, the data will be cleared for both features

[Miraeld]

Hello hello,

It seems to me the AC #1 is already covered.

For AC #2, @piotrbak could you confirm something: If one of these features: LRC OR OCI is disabled, we still display the clearing button for both features?

Thank you

[Miraeld]

Otherwise, for AC 3,

Scope a solution

In

wp-rocket/inc/Engine/Common/PerformanceHints/Admin/AdminBar.php

Line 95 in 1f82fa0

public function display_dashboard_button() {

, we would need to add the following:

		$all_not_allowed = true;

		foreach ($this->factories as $factory) {
			if ($factory->get_context()->is_allowed()) {
				$all_not_allowed = false;
				break;
			}
		}

		if ($all_not_allowed) {
			return;
		}

In this case, if every factories return false to is_allowed() we will not display the option to clear the data.

Also, for AC 2, it will shows the option if at least one feature is enabled.

[Khadreal]

The factories are loaded if the context is true, so we could just check if it's empty at this point. Also, the lrc_factory context check is missing there.

wp-rocket/inc/Engine/Common/PerformanceHints/ServiceProvider.php

Line 75 in 1f82fa0

if ( $atf_factory->get_context()->is_allowed() ) {

[Edit]
The dashboard button trait class already check for this

wp-rocket/inc/Engine/Admin/Settings/AdminBarMenuTrait.php

Lines 134 to 136 in 1f82fa0

	if ( ! $context ) {
	return;
	}

. What we need to do will be to load the lrc_factory in the serviceprovider class

[piotrbak]

@Miraeld If one of these features: LRC OR OCI is disabled, we still display the clearing button for both features?

Yes, that's correct

[Khadreal]

@Miraeld I can see factories is being added, what we need to do will be to test this scenarios esp AC 3 to confirm everything is fine

[Miraeld]

Yes,

For AC 1 & 2, its already working like we want.
However for 3 we need to implement what I've recommended earlier.

Also, for all three scenarios, we need to implement tests to make sure it's working as expected.

[jeawhanlee]

@Miraeld @Khadreal I don't think we have issues with the clear button displays whether on the dashboard or the admin bar menu.
What I think we need to check is if we clear the data as expected for those 3 ACs

[Khadreal]

@jeawhanlee spot on. I think we're good on that. The data cleared as expected. Moving this to QA

[Khadreal]

Video recording showing the filter activation and deactivation
https://www.loom.com/share/f02029def0e84c3d94a331de489f5b8b?sid=509959fd-2729-4bd7-b7af-4174fea70afb