Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6878 Activation and deactivation of Performance hints data filters #6928

Merged

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Aug 29, 2024

Description

Make sure data are cleared when filters are deactivated.

Fixes #6878

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Disabled the performance filters and try to switch theme, change permalinks, post trash or delete, the data aren't cleared. Data should be cleared as specified in the Epic Card

Technical description

Remove the logic check for filters when any of this action is taken.

Documentation

Ensure the data are cleared as specified either when the filters are activated or deactivated.

New dependencies

N/A

Risks

N//A

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I did not introduce unnecessary complexity.

@Khadreal Khadreal added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement module: OCI Optimize Critical Images module: ALR Issues related to the Automatic Lazy Rendering feature labels Aug 29, 2024
@Khadreal Khadreal self-assigned this Aug 29, 2024
Copy link

codacy-production bot commented Aug 29, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -0.10%) 90.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (30fb031) 37925 16540 43.61%
Head commit (dffd9df) 37912 (-13) 16541 (+1) 43.63% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6928) 10 9 90.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@Khadreal Khadreal requested a review from a team August 29, 2024 09:36
@Khadreal Khadreal linked an issue Aug 29, 2024 that may be closed by this pull request
@Khadreal Khadreal force-pushed the enhancement/6878-activation-deactivation-filters branch from e28312d to 3424284 Compare August 30, 2024 17:00
@Mai-Saad
Copy link
Contributor

Mai-Saad commented Sep 2, 2024

@Khadreal Thanks for the PR and the video.
@piotrbak if lcp or lrc is off, clear performance hints will clear only the active option not both. Do you think this is ok? or should we clear both in this case? (this applies to clear performance hints and clear performance hints for this URL)

@Khadreal
Copy link
Contributor Author

Khadreal commented Sep 2, 2024

@Mai-Saad the data of both should be cleared not only the active one.

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Sep 2, 2024

@Khadreal You are right, rechecked on PR and it's working 🙏

@Khadreal Khadreal merged commit 4d7b54b into feature/lrc Sep 2, 2024
13 checks passed
@Khadreal Khadreal deleted the enhancement/6878-activation-deactivation-filters branch September 2, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: ALR Issues related to the Automatic Lazy Rendering feature module: OCI Optimize Critical Images type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.17 - Activation/Deactivation with the filters
3 participants