-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #6878 Activation and deactivation of Performance hints data filters #6928
Closes #6878 Activation and deactivation of Performance hints data filters #6928
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
e28312d
to
3424284
Compare
@Mai-Saad the data of both should be cleared not only the active one. |
@Khadreal You are right, rechecked on PR and it's working 🙏 |
Description
Make sure data are cleared when filters are deactivated.
Fixes #6878
Type of change
Detailed scenario
Disabled the performance filters and try to switch theme, change permalinks, post trash or delete, the data aren't cleared. Data should be cleared as specified in the Epic Card
Technical description
Remove the logic check for filters when any of this action is taken.
Documentation
Ensure the data are cleared as specified either when the filters are activated or deactivated.
New dependencies
N/A
Risks
N//A
Mandatory Checklist
Code validation
Code style