Fix #6526 LCP/ATF messages that is not working correctly

[Khadreal]

Description

Fixed ATF/LCP message not showing

Fixes #6526

Documentation

User documentation

Explain how this code impacts users.

Technical documentation

Explain how this code works. Diagram & drawings are welcomed.

Type of change

• Bug fix (non-breaking change which fixes an issue).

New dependencies

List any new dependencies that are required for this change.

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Checklists

Feature validation

• I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I implemented built-in tests to cover the new/changed code.

Code style

• I wrote self-explanatory code about what it does.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.03% (target: -0.10%)	❌ 30.00% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (1c4062a)	36764	8212	22.34%
Head commit (e523287)	36828 (+64)	8216 (+4)	22.31% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6562)	10	3	30.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{The deprecated coverage status is not being sent today as part of the scheduled brownout. Know more}

[remyperona]

Changes LGTM, can you update:

• The PR title to respect our naming convention
• The checklist
• The assignee, label, milestone

[Mai-Saad]

@Khadreal Thanks for the PR. Please find exploratory test notes below:

1. The successful old RUCSS notice with a fresh install of 3.16 is still displayed
2. The new notices when enabling RUCSS aren't displayed => counter https://github.com/wp-media/wp-rocket/pull/6562/files#diff-25f931bcb7ef216b9bad8ed4e4827d5207d72c450cc54a27e5e0db362be9e8cdR104 and success https://github.com/wp-media/wp-rocket/pull/6562/files#diff-25f931bcb7ef216b9bad8ed4e4827d5207d72c450cc54a27e5e0db362be9e8cdR147
3. @piotrbak Do we need any updates in the notice for nulled license https://github.com/wp-media/wp-rocket/pull/6562/files#diff-25f931bcb7ef216b9bad8ed4e4827d5207d72c450cc54a27e5e0db362be9e8cdR232 ?

For testing the PR

• Related test run https://wpmediaqa.testrail.io/index.php?/runs/view/842&group_by=cases:section_id&group_order=asc
• We need to explore what will happen when updating while RUCSS is on/off in terms of msgs
• Rollback while blocking external request caused error => we need to explore Rollback in this case while RUCSS is on/off (may be it's due BG process)
  debug.log

[jeawhanlee]

@Khadreal

Something overlooked during the grooming:

• We need to also check here if RUCSS is disabled
  

  wp-rocket/inc/Engine/Saas/Admin/Notices.php

  Line 141 in 88ceebf

  if ( false !== $transient ) {

we can do something like this: if ( false !== $transient || ( ! $this->options->get( 'remove_unused_css', 0 ) ) )

Somethings that was not implemented in this PR:

• I can see this here was not updated to rocket_saas_processing
• The updated script was not also bundled, try using gulp run:build
• And I think we need to update related tests that still have rocket_rucss_processing
• The messages has not been updated to those on the epic: https://www.notion.so/wpmedia/Beacon-Auto-optimize-LCP-image-Auto-exclude-images-above-the-fold-from-LazyLoad-56226bccec874b45aed4a57f08690029?pvs=4#29b2990bb3d34436930a5577b66881e1

[Khadreal]

@jeawhanlee not just that, the get_transient is still referencing the old value on line 138. I've changed that and couple of other things

[MathieuLamiot]

@Khadreal I checked [the test plan shared by Mai above]. There are issues for 2 tests related to this PR I think. Can you check? (https://wpmediaqa.testrail.io/index.php?/runs/view/842&group_by=cases:section_id&group_order=asc):

• Shouldn't display any notice after fresh install of 3.16: This is still failing with this PR

Enregistrement.de.l.ecran.2024-04-24.a.19.15.19.mov

• Should display new success notice after RUCSS is generated: Just after activating I have the message but there are two dots at the end.

• Should display notice while API URL not reachable even if RUCSS is off: for step 1, I add to click "Clear Critical Images" to trigger the SaaS requests and hence the banner. I think it's OK and the test step should just be more precise (@Mai-Saad). Other than that ✅

• Should display banner when license is expired /about to expire : ✅

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +15.97% (target: -0.10%)	❌ 45.45% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (1c4062a)	36764	8212	22.34%
Head commit (6af9077)	36974 (+210)	14164 (+5952)	38.31% (+15.97%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6562)	11	5	45.45%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more}

[MathieuLamiot]

All good now https://wpmediaqa.testrail.io/index.php?/runs/view/842&group_by=cases:section_id&group_order=asc