Fix/update default fetched links to 10 and parse unappended url to is home

[jeawhanlee]

Description

Fetches 10 links from home plus home(11) and also fixes the is_home not detecting the homepage.

Fixes: Addresses @hanna-meda comment here and here

Documentation

User documentation

Explain how this code impacts users.

Technical documentation

wp-rocket/inc/Engine/Media/AboveTheFold/WarmUp/APIClient.php

Line 17 in 38775e5

public function add_to_atf_queue( string $url ): array {

We now save the original url before appending the query strings then reuse the version in is_home method
Also we now filter out the home url from the links if it exists and append in the end just before returning the urls, reason for this is to always return the home url for templates that might not contain the home url.

Type of change

• Bug fix (non-breaking change which fixes an issue).

New dependencies

None

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Checklists

Feature validation

• I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I implemented built-in tests to cover the new/changed code.

Documentation

• I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
• The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
• I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

• I wrote self-explanatory code about what it does.
• I wrote comments to explain why it does it.
• I named variables and functions explicitely.
• I protected entry points against unexpected inputs.
• I did not introduce unecessary complexity.
• I listed the introduced external dependencies explicitely on the PR.
• I validated the repo-specific guidelines from CONTRIBUTING.md.

Observability

• I handled errors when needed.
•  I wrote user-facing messages that are understandable and provide actionable feedbacks.
• I prepared ways to observe the implemented system (logs, data, etc.).

Risks

•  I explicitely mentioned performance risks in the PR.
• I explicitely mentioned security risks in the PR.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for e31b05b1	✅ 71.43% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (e31b05b)	Report Missing	Report Missing	Report Missing
Head commit (0328cda)	36824	8216	22.31%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6563)	7	5	71.43%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[remyperona]

Is this change necessary?

[jeawhanlee]

Yes I believe it is, in reference to @hanna-meda comment here

[remyperona]

I'm failing to understand the difference it makes, it's the same code assigned to a variable?

[jeawhanlee]

Yes but we are now preserving the original state of the url param which was not the case before as we alter the state here first then we use it here which in the is_home method here we will always return false even if it's the home page because it's now appended with a query string i.e example.org?wpr_imagedimensions=1

[remyperona]

ah yes right, I see now, all good