Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6509 Don't display clear critical images for this URL on admin view #6565

Merged

Conversation

remyperona
Copy link
Contributor

Description

The admin menu item only needs to be displayed on frontend view

Fixes #6509

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

@remyperona remyperona added type: bug Indicates an unexpected problem or unintended behavior lcp labels Apr 16, 2024
@remyperona remyperona added this to the 3.16 milestone Apr 16, 2024
@remyperona remyperona self-assigned this Apr 16, 2024
@remyperona remyperona changed the base branch from develop to feature/lcp-above-the-fold-optimization April 16, 2024 21:18
@remyperona remyperona requested a review from a team April 16, 2024 21:19
Copy link

codacy-production bot commented Apr 16, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+16.01% (target: -0.10%) 100.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (af00697) 36824 8216 22.31%
Head commit (8e2ba0a) 36827 (+3) 14112 (+5896) 38.32% (+16.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6565) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@wp-media wp-media deleted a comment from codacy-production bot Apr 16, 2024
@Mai-Saad
Copy link
Contributor

Mai-Saad commented Apr 19, 2024

@Miraeld
Copy link
Contributor

Miraeld commented Apr 24, 2024

Tests are all green.
testrail-report-598.pdf

@Miraeld Miraeld merged commit 66356a9 into feature/lcp-above-the-fold-optimization Apr 24, 2024
13 checks passed
@Miraeld Miraeld deleted the fix/6509-clear-admin-url branch April 24, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clear critical images inside admin bar is duplicated in edit page view
4 participants