-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #6922 3.17: Hashes are not removed from the source when there is no LRC data #6937
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
inc/Engine/Optimization/LazyRenderContent/Frontend/Controller.php
Outdated
Show resolved
Hide resolved
related test plan https://wpmediaqa.testrail.io/index.php?/runs/view/894 |
Test plan all 🆗 for me. @wp-media/qa-team Feel free to merge or explore more if you prefer 👍 |
Description
Hashes should be removed when visiting uncached page that have [] LRC in DB
Fixes #6922
Type of change
Detailed scenario
Please check #6922 for detailed scenario.
Technical description
Update
has_lrc
method in LazyRenderContent database row to check for'[]'
instead of 'not found' which doesn't exist in db records and updated theoptimize
method to return html without hashes when the logic checks passed.Documentation
Hashes should be removed when visiting uncached page that have [] LRC in DB
Mandatory Checklist
Code validation
Code style