-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7143 Update file structure for local fonts & CSS fonts #7166
Fixes #7143 Update file structure for local fonts & CSS fonts #7166
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @remyperona, for this PR.
I can confirm that:
✓ the hash is no longer added to the font file
✓ google-font folder is now google-fonts
✓ CSS is stored under css sub-directory: cache/fonts/1/google-fonts/css
✓ Fonts are stored under fonts sub-directory: cache/fonts/1/google-fonts/fonts
Description
Fixes #7143
Type of change
Detailed scenario
The following structure is now used:
google-fonts
google-fonts/css
foldergoogle-fonts/fonts
folderTechnical description
Documentation
Updated the code for the file structure to reflect the needed changes. Also added a check for the local CSS file, to skip the file creation if it already exists.
Mandatory Checklist
Code validation
Code style
Additional Checks