Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7143 Update file structure for local fonts & CSS fonts #7166

Merged
merged 10 commits into from
Dec 4, 2024

Conversation

remyperona
Copy link
Contributor

Description

Fixes #7143

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Detailed scenario

The following structure is now used:

  • base directory is google-fonts
  • CSS files are saved in the google-fonts/css folder
  • Fonts files are saved in the google-fonts/fonts folder

Technical description

Documentation

Updated the code for the file structure to reflect the needed changes. Also added a check for the local CSS file, to skip the file creation if it already exists.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@remyperona remyperona added the type: sub-task Indicates the issue is a sub-task linked to an epics card label Dec 3, 2024
@remyperona remyperona added this to the 3.18 milestone Dec 3, 2024
@remyperona remyperona requested a review from a team December 3, 2024 20:29
@remyperona remyperona self-assigned this Dec 3, 2024
Copy link

codacy-production bot commented Dec 3, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) 85.19% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d285f66) 38425 16870 43.90%
Head commit (a9c8333) 38431 (+6) 16873 (+3) 43.90% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7166) 27 23 85.19%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @remyperona, for this PR.
I can confirm that:
✓ the hash is no longer added to the font file
✓ google-font folder is now google-fonts
✓ CSS is stored under css sub-directory: cache/fonts/1/google-fonts/css
✓ Fonts are stored under fonts sub-directory: cache/fonts/1/google-fonts/fonts

@hanna-meda hanna-meda merged commit b96427d into feature/host-google-fonts Dec 4, 2024
13 checks passed
@hanna-meda hanna-meda deleted the fix/7143-update-structure branch December 4, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: sub-task Indicates the issue is a sub-task linked to an epics card
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.18: the local hosted google font file shall match the required structure
3 participants