CMake sanitize leading define flag #2130
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: compilation, cmake
SOURCE: internal
DESCRIPTION OF CHANGES:
Problem:
With the addition of #2088,
ARCH_LOCAL
from the stanza is now being fed into compilation with potential-D
defines. On versions of CMake <3.26 leading-D
on defines is not removed from certain function calls likeadd_compile_definitions()
. This will pass the configuration stage but will fail to compile when using the defined minimum CMake version of the project.Solution:
To simplify the logic, all defines fed into the
wrf_config.cmake
file for the configuration step will be sanitized of leading-D
. This follows the original design intent where stanza sanitization happens before being fed into CMake, thus allowing the CMake code to focus on configuration of options rather than translation of stanza into usable values.TESTS CONDUCTED:
RELEASE NOTE:
Remove leading -D on defines during stanza reading to allow older versions of CMake to configure properly.