Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When write_hist_at_0h_rst=.true., will now apply to user-def streams #2133

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jhruppert
Copy link
Contributor

@jhruppert jhruppert commented Nov 17, 2024

The first line should be a single-line "purpose" for this change

TYPE: bug fix/enhancement

KEYWORDS: wrf, wrfv4, restart, output streams

SOURCE: James Ruppert (University of Oklahoma)

DESCRIPTION OF CHANGES:
Problem:
When running WRF from as a restart, the option write_hist_at_0h_rst would only apply to the default history stream. Now, when this option is set to true, it will also apply to special user-defined streams. This is required to maintain a consistent number of output time steps per file with multiple time steps writing to a single file, which is often preferred for multiple-day runs.

Solution:
Added an additional loop over history streams with CALL med_hist_out when the following condition is met:
IF ( (config_flags%restart) .AND. ( currTime .EQ. startTime ) .AND. ( config_flags%write_hist_at_0h_rst ))

ISSUE: For use when this PR closes an issue.
While it's apparently not a very common need, it is something we are now using across multiple projects (and likely more in the future) so it would help to have it included moving forward. There is a thread on the wrf forum at https://forum.mmm.ucar.edu/threads/to-the-wrf-developers-write_hist_at_0h_rst-for-user-defined-output-streams.16824/

LIST OF MODIFIED FILES:
share/mediation_integrate.F

TESTS CONDUCTED:

  1. Verified that this change works: when option is set to true, history write-out at first time step of a restart now applies to both the default history stream and a user-defined stream (tested with stream 7).
  2. None of the Jenkins tests appear to fail.

RELEASE NOTE:
When the namelist option write_hist_at_0h_rst is set to .true. under &time_control, history write-out will now be conducted for the first time step for both the 0th stream (wrfout* files) and any special user-defined streams being implemented.

@jhruppert jhruppert requested review from a team as code owners November 17, 2024 22:41
@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar weiwangncar changed the base branch from master to develop November 18, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants