Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge private subnet changes up #143

Merged
merged 12 commits into from
Apr 29, 2024
Merged

Merge private subnet changes up #143

merged 12 commits into from
Apr 29, 2024

Conversation

dmannarino
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

dmannarino and others added 10 commits October 16, 2023 14:03
@dmannarino
Merge pull request #136 from wri/master
b79bafb 
Merge down index of None hotfix
@danscales
Increase timeout for GADM job of integrated_alerts
36ef14d 
Increase time to 6 hours from default timeout of 4 hours for GADM job of
integrated_alerts.
@danscales
Merge pull request #137 from wri/increaseGadmTimeout
a642d3b 
Increase timeout for GADM job of integrated_alerts
@danscales
Revert timeout increase for gadm
8faa931 
The timeout was caused by a big DB ingestion job that was preventing all
other DB ingestion jobs from running, so gadm timeout increase doesn't
really help generally.
@dmannarino
Disable use of public subnets for EMR
816e5c7
@dmannarino
Revert "Disable use of public subnets for EMR"
0809c32 
This reverts commit 816e5c7.
@dmannarino
Use private subnet IDs for EMR jobs
cddf74a
@dmannarino
Missed a reference to public_subnet_ids
c4c48c5
@solomon-negusse
stagger VIIRS and GLAD cron schedules
1a04333
@dmannarino
Merge pull request #141 from wri/emr_use_private_subnets
4888c72 
GTC-2786 : Use private subnets for EMR
@dmannarino dmannarino requested a review from jterry64 April 25, 2024 17:55
@dmannarino dmannarino merged commit c6b719a into master Apr 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jterry64 jterry64 jterry64 approved these changes

@solomon-negusse solomon-negusse Awaiting requested review from solomon-negusse

@danscales danscales Awaiting requested review from danscales

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmannarino @jterry64 @danscales @solomon-negusse