-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing start and end dates for RW areas sync #177
Conversation
Use hash index for geostore integrated alerts table instead of btree
Use btree index instead of hash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad this was a small change. Looks good, @jterry64 ! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but would be good to fix the wrong indent in sync.py.
src/datapump/sync/sync.py
Outdated
def __init__(self, sync_types: List[SyncType], sync_version: str = None): | ||
self.sync_version: str = ( | ||
def __init__(self, sync_types: List[SyncType], sync_version: str = None, **kwargs): | ||
self.sync_version: str = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is indented wrong. Should be four more spaces. I guess maybe Python understands because it's right after the ':" of the function definition, but would be good to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out my pre-commit linter wasn't set up properly! Still need to test it all out
Also fixed some flake8 whitespace warnings.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Previously, we assumed the
/v2/areas/sync
API syncs all pending areas to the DB, and then returns all areas still pending. However, it turns out it only returns pending areas in the specified date range. This is max the past 2 days, but we added a change a few months to filter to the past 1 day, since sometimes it was timing out.This has a few implications:
What is the new behavior?
Does this introduce a breaking change?
Other information