FLAG-1154: update dashboard sentences for natural forest #4884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wri7tno
commented
Nov 12, 2024
services/sentences.js
Outdated
| getLoss(params), | ||
| getLoss({ ...params, forestType: 'plantations' }), | ||
| getLoss({ ...params, forestType: 'primary_forest' }), | ||
| ]).then( |
There was a problem hiding this comment.
to this day I really don't know why this function is invoking 3 times getExtent and getLoss with different params,
also I ignore if they are used in a specific page besides the dashboard
wri7tno
commented
Nov 12, 2024
| emissions: 0, | ||
| }, | ||
| primaryLoss: {}, | ||
| }; |
There was a problem hiding this comment.
looks like the dashboard sentences only require the following:
- totalArea
- extent
- totalLoss: {
area,
year,
emissions,
}
hence I left the others with 0
wri7tno
force-pushed
the
feat/FLAG-1154
branch
from
f36a052
to
a0c1203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
With Natural Forest epic, the dashboard sentences need to be updated, this PR address that.
Demo
If applicable: screenshots, gifs, etc.
Notes
If applicable: ancilary topics, caveats, alternative strategies that didn't work out, etc.
Testing