PuDBWrapper#pytest_exception_interact: Remove call to self.disable_io_capture()
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdedos
force-pushed
the
fix/remove-double-prologue
branch
2 times, most recently
from
a25567a to
7baecab
Compare
…_io_capture()` It is not needed, since the calling chain: - `_enter_pudb` - `post_mortem` - `pudb._get_debugger()` will still call `PuDBWrapper#_get_debugger`, which also calls `self.disable_io_capture()` Avoids the double-prologue: ```console $ pytest -x --pudb ======================================= test session starts ======================================== platform linux -- Python 3.9.16, pytest-7.2.1, pluggy-1.0.0 rootdir: .., configfile: pyproject.toml plugins: pycharm-0.7.0, pudb-0.7.0, dash-2.8.1, cov-4.0.0 collected 1726 items ../tests/test_parsers.py F >>>>>>>>>>>>>>>>>>>>>>>>>>>>> entering PuDB (IO-capturing turned off) >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>>>>>>>> entering PuDB (IO-capturing turned off) >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> ===================================== short test summary info ====================================== FAILED ../tests/test_parsers.py::test_parse[..] - KeyError: "None of ['taskID'] are in the columns" !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! ======================================== 1 failed in 2.48s ========================================= ``` vs ```console $ pytest -x --pudb ======================================= test session starts ======================================== platform linux -- Python 3.9.16, pytest-7.2.1, pluggy-1.0.0 rootdir: .., configfile: pyproject.toml plugins: pycharm-0.7.0, pudb-0.7.0, dash-2.8.1, cov-4.0.0 collected 1726 items ../tests/test_parsers.py F >>>>>>>>>>>>>>>>>>>>>>>>>>>>> entering PuDB (IO-capturing turned off) >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> ===================================== short test summary info ====================================== FAILED ../tests/test_parsers.py::test_parse[..] - KeyError: "None of ['taskID'] are in the columns" !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! ======================================== 1 failed in 3.62s ========================================= ``` Cannot do the opposite thing, since then `pu.db` and friends will loose the opportunity to do prologue (`pytest_exception_interact` is called only via the `--pudb` flag) Additionally, update `.gitignore` (via github/gitignore@8e67b94) Signed-off-by: Stavros Ntentos <[email protected]>
stdedos
force-pushed
the
fix/remove-double-prologue
branch
from
7baecab to
d9efd87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not needed, since the calling chain:
_enter_pudbpost_mortempudb._get_debugger()will still call
PuDBWrapper#_get_debugger, which also callsself.disable_io_capture()Avoids the double-prologue:
vs
Cannot do the opposite thing, since then
pu.dband friends will loose the opportunity to do prologue(
pytest_exception_interactis called only via the--pudbflag)Signed-off-by: Stavros Ntentos [email protected]