Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BasicAuth flow if shared app is a public client #50

Merged

Conversation

HasiniSama
Copy link
Contributor

@HasiniSama HasiniSama commented Oct 29, 2024

Purpose

$subject

Issue: wso2/product-is#21222

Fixes the second/third tasks of the above issue.

  1. If the shared application is marked as an isPublicClient application, the BasicAuth is enabled.

Related PRs

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.95%. Comparing base (436a76a) to head (9ee784e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #50      +/-   ##
============================================
- Coverage     42.46%   36.95%   -5.51%     
+ Complexity       77       71       -6     
============================================
  Files             3        3              
  Lines           504      506       +2     
  Branches         65       66       +1     
============================================
- Hits            214      187      -27     
- Misses          256      288      +32     
+ Partials         34       31       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HasiniSama HasiniSama force-pushed the shared-app-public-client branch from c4407d5 to 5624bc8 Compare November 1, 2024 09:42
@HasiniSama HasiniSama force-pushed the shared-app-public-client branch from 5624bc8 to 9ee784e Compare November 1, 2024 09:43
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11699929100

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11699929100
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11699929100

@sadilchamishka sadilchamishka merged commit af4f1c8 into wso2-extensions:main Nov 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants