Authorization valve and tenant context valve improvements for support B2B use cases #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadilchamishka
force-pushed
the
improve-authorization-valve-for-organization-login-users
branch
from
b5394fb to
aa26c66
Compare
sadilchamishka
changed the title
sadilchamishka
force-pushed
the
improve-authorization-valve-for-organization-login-users
branch
from
aa26c66 to
b39db5a
Compare
...rbon.identity.authz.valve/src/main/java/org/wso2/carbon/identity/authz/valve/util/Utils.java
Show resolved
Hide resolved
sadilchamishka
force-pushed
the
improve-authorization-valve-for-organization-login-users
branch
2 times, most recently
from
9be3cea to
e4dc253
Compare
|
PR builder started |
sadilchamishka
changed the title
|
PR builder completed |
sadilchamishka
force-pushed
the
improve-authorization-valve-for-organization-login-users
branch
from
bf2043a to
3e9aff5
Compare
sadilchamishka
force-pushed
the
improve-authorization-valve-for-organization-login-users
branch
from
3e9aff5 to
c71a43a
Compare
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6542360509
thanujalk
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
As for now, authorization valve validate whether the authenticated user's tenant domain is same as the accessed tenant qualified resource path. If the request is organization qualified, it will be convert to tenant domain to do the mentioned comparison.
With this effort, the tenant qualified URLs and organization qualified URLs are treated separately.
1 - For tenant qualified paths, the previous logic is preserved.
2 - For organization qualified paths, the organization qualified path and the organization where the token is bound should be same. In order to keep the backward compatibility for organization qualified path (there can be tokens without organization bounded tokens to access organization qualified resources), the previous logic [1] is preserved.
[1] - https://github.com/wso2-extensions/identity-carbon-auth-rest/pull/242/files#diff-5c23026718f023a28a31deb8b3b2d38a1d587c41866b829b28ba63c9a72dc91cR104
Also, the organization bound tokens are allowed to be invoked with the root tenant path. When accessing a resources via root tenant URL path with an organization bound token, an organization scoped tenant flow is started to access only the organization scoped resources.
Related Issues.
When should this PR be merged
Depends on