Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usages of auth config with app version #2592

Merged
merged 10 commits into from
Oct 28, 2024
Merged

Replace usages of auth config with app version #2592

merged 10 commits into from
Oct 28, 2024

Conversation

mpmadhavig
Copy link
Contributor

Proposed changes in this pull request

This PR will use app version v2.0.0 to bring behavioral changes introduced in access token claims.

Related issues:

@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 44.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 55.85%. Comparing base (afd5acb) to head (e69efc6).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
...2/carbon/identity/oauth/OAuthAdminServiceImpl.java 14.28% 11 Missing and 1 partial ⚠️
...arbon/identity/oauth2/token/AccessTokenIssuer.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2592      +/-   ##
============================================
- Coverage     56.23%   55.85%   -0.38%     
+ Complexity     8128     8104      -24     
============================================
  Files           632      632              
  Lines         46158    46394     +236     
  Branches       7771     7838      +67     
============================================
- Hits          25956    25914      -42     
- Misses        16478    16768     +290     
+ Partials       3724     3712      -12
Flag Coverage Δ
unit 38.50% <44.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11496941699

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11496941699
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11497607352

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11497607352
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11497607352

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11497607352
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11497607352

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11497607352
Status: failure

@mpmadhavig
Copy link
Contributor Author

Integration failures will be fixed with wso2/product-is#21446

@mpmadhavig mpmadhavig force-pushed the jwt-claims branch 5 times, most recently from ba9c9e9 to ab3ee9f Compare October 25, 2024 09:24
@mpmadhavig mpmadhavig force-pushed the jwt-claims branch 2 times, most recently from 3ef1b1f to 660bb7e Compare October 25, 2024 11:48
@mpmadhavig mpmadhavig merged commit 16fe5aa into wso2-extensions:master Oct 28, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMHP DMHP DMHP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpmadhavig @jenkins-is-staging @DMHP