Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude OIDC Session Management for Secondary Device in Device Grant Flow #2639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SujanSanjula96
Copy link
Contributor

Proposed changes in this pull request

From this PR, OIDC Session Management is excluded for Secondary Device in Device Grant Flow. With that, NPE when getting session state param due to null callback URL is fixed.

Issue - wso2/product-is#16867

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12131667424

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.44%. Comparing base (654bc26) to head (b449b90).

Files with missing lines Patch % Lines
...tity/oauth/endpoint/authz/OAuth2AuthzEndpoint.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2639      +/-   ##
============================================
+ Coverage     56.43%   56.44%   +0.01%     
+ Complexity     8188     8180       -8     
============================================
  Files           632      632              
  Lines         46323    46323              
  Branches       8245     8245              
============================================
+ Hits          26141    26148       +7     
+ Misses        16469    16457      -12     
- Partials       3713     3718       +5     
Flag Coverage Δ
unit 38.68% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12131667424
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12131667424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants