Feature/grpc #2369
Closed
Feature/grpc #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krishanx92
added
the
trigger-action
removed duplicate function
github-actions
bot
removed
the
trigger-action
O-sura
added
the
trigger-action
github-actions
bot
removed
the
trigger-action
AmaliMatharaarachchi
added
the
trigger-action
AmaliMatharaarachchi
approved these changes
May 14, 2024
ShammiL
reviewed
Jun 4, 2024
|
|
||
| private static final Logger logger = LogManager.getLogger(GRPCAPI.class); | ||
| private final List<Filter> filters = new ArrayList<>(); | ||
| private APIConfig apiConfig; |
There was a problem hiding this comment.
Suggested change
| private APIConfig apiConfig; | |
| private APIConfig apiConfig; | |
ShammiL
reviewed
Jun 4, 2024
Comment on lines
+108
to
+109
|
|
||
|
|
There was a problem hiding this comment.
You could remove the extra spaces here and there
| @@ -280,6 +280,14 @@ public class APIClient { | |||
| return fullBasePath; | |||
| } | |||
|
|
|||
| isolated function returnFullGRPCBasePath(string basePath, string 'version) returns string { | |||
| string fullBasePath = basePath; | |||
| if (!string:endsWith(basePath, 'version)) { | |||
There was a problem hiding this comment.
Suggested change
| if (!string:endsWith(basePath, 'version)) { | |
| if !string:endsWith(basePath, 'version) { |
| @@ -448,6 +456,19 @@ public class APIClient { | |||
| sandboxRoutes.push(gqlRoute.metadata.name); | |||
| } | |||
| } | |||
| } else if apkConf.'type == API_TYPE_GRPC{ | |||
There was a problem hiding this comment.
Suggested change
| } else if apkConf.'type == API_TYPE_GRPC{ | |
| } else if apkConf.'type == API_TYPE_GRPC { |
ShammiL
reviewed
Jun 4, 2024
Comment on lines
+893
to
+895
| } else { | ||
| return e909022("Provided Type currently not supported for GRPC APIs.", error("Provided Type currently not supported for GRPC APIs.")); | ||
| } |
There was a problem hiding this comment.
since the if has a return we don't need the else here
| } | ||
| } | ||
| if operation.operationPolicies != () { | ||
| model:APIPolicy? apiPolicyCR = check self.generateAPIPolicyAndBackendCR(apiArtifact, apkConf, operation, operation.operationPolicies, organization, apiArtifact.uniqueId); |
There was a problem hiding this comment.
Break the long statements into few lines if possible
| @@ -1564,6 +1696,11 @@ public class APIClient { | |||
| return hashedValue.toBase16(); | |||
| } | |||
|
|
|||
| public isolated function getUniqueNameForGrpcApi(string concatanatedServices) returns string { | |||
There was a problem hiding this comment.
Let's have doc comments for public functions
| log:printError("Error occured while deleting GrpcRoute", grpcRouteDeletionResponse); | ||
| } | ||
| } | ||
| return; |
ShammiL
reviewed
Jun 4, 2024
Comment on lines
+129
to
+132
| public List<String> getMethods(Service Service){ | ||
| return Service.methods; | ||
| } | ||
| public List<Service> getServices(){ |
There was a problem hiding this comment.
Let's doc comments to these public methods
ShammiL
reviewed
Jun 4, 2024
| '}'; | ||
| } | ||
| } | ||
| } |
|
Track with #2438 |
github-actions
bot
removed
the
trigger-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning