Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new config to specify to append super tenant in URL #4990

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Add new config to specify to append super tenant in URL #4990

merged 3 commits into from
Oct 18, 2023

Conversation

Thisara-Welmilla
Copy link
Contributor

Related issue:

Add new configurations to specify where carbon.super is needed to append to the URL when tenant qualified URL feature is enabled.

@Thisara-Welmilla Thisara-Welmilla mentioned this pull request Oct 11, 2023
Closed
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-new-config branch 4 times, most recently from 1667875 to cd2896e Compare October 16, 2023 09:32
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6531724477

@Thisara-Welmilla Thisara-Welmilla force-pushed the add-new-config branch 2 times, most recently from 53cc134 to 38ad68a Compare October 16, 2023 09:39
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6531724477
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6532934912

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6532934912
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6541390477

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6541390477
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6542421640

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6542421640
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6545990248

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6545990248
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 17, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6545990248

@Thisara-Welmilla Thisara-Welmilla merged commit cf11a61 into wso2:master Oct 18, 2023
@Avarjana Avarjana mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnuradhaSK AnuradhaSK AnuradhaSK left review comments

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@chamathns chamathns chamathns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thisara-Welmilla @jenkins-is-staging @chamathns @AnuradhaSK