Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve framework to resolve the definedBy authenticator property #6029

Conversation

Thisara-Welmilla
Copy link
Contributor

Task Issue:

With the above issue, we introduce new authenticator config :definedBy. This PR to add the code logic do following.

  • Check Federated authenticator in the IDP, have definedBy property, if not resolve it.
  • For new federated authenticators: If 'definedByType' is null, set it to default to SYSTEM.
  • For existing federated authenticators, disregard any value provided in the request payload. Instead, resolve and retrieve the 'definedBy' type of the corresponding existing authenticator. If the authenticator config is present in the ApplicationAuthenticatorService list, return its type, if not return USER.

@Thisara-Welmilla Thisara-Welmilla marked this pull request as ready for review October 15, 2024 09:02
@Thisara-Welmilla Thisara-Welmilla merged commit bdc2fb4 into wso2:add-definedBy-Type Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants