Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to the IdentityProviderManagementClientException class. #6174

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Dec 4, 2024

Issue:

Related PRs:

Add new method to take both error message and error discription as input parameters for IdentityProviderManagementClientException.

Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.02%. Comparing base (441034e) to head (145665f).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
...mgt/IdentityProviderManagementClientException.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6174      +/-   ##
============================================
+ Coverage     44.72%   45.02%   +0.30%     
+ Complexity    13810    13679     -131     
============================================
  Files          1606     1606              
  Lines        102116    99398    -2718     
  Branches      17215    16761     -454     
============================================
- Hits          45670    44755     -915     
+ Misses        49663    48002    -1661     
+ Partials       6783     6641     -142     
Flag Coverage Δ
unit 27.28% <0.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thisara-Welmilla
Copy link
Contributor Author

Quality Gate Failed Quality Gate failed

Failed conditions B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

This suggest to make descriotion variable final. But it is impossible to do as there are muliple constructor for that class and only one constructor setting that variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants