Introduce the fragment app check when adding the app role association

[ShanChathusanda93]

Proposed changes in this pull request

• $subject
• Part of the fix : Support for creating OAuth 2.0 clients inside B2B organizations for B2B API access product-is#21208
• Sub organization can have both sub org roles and shared roles.
• When it comes to shared roles, the app to role association is not needed with the fragment app / shared app in the sub organization level.

[codecov]

Codecov Report

Attention: Patch coverage is 47.91667% with 25 lines in your changes missing coverage. Please review.

Project coverage is 45.56%. Comparing base (b4c7215) to head (03e663d).
Report is 116 commits behind head on master.

Files with missing lines	Patch %	Lines
...ty/role/v2/mgt/core/RoleManagementServiceImpl.java	48.48%	9 Missing and 8 partials ⚠️
...on/mgt/listener/DefaultRoleManagementListener.java	0.00%	8 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #6185      +/-   ##
============================================
+ Coverage     40.93%   45.56%   +4.63%     
+ Complexity    15735    14108    -1627     
============================================
  Files          1812     1631     -181     
  Lines        126414   100847   -25567     
  Branches      22448    16960    -5488     
============================================
- Hits          51746    45951    -5795     
+ Misses        67057    48194   -18863     
+ Partials       7611     6702     -909     

Flag	Coverage Δ
unit	28.31% <47.91%> (+0.14%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AnuradhaSK]

Add unit test to cover changed code

[AnuradhaSK]

Here can't we validate whether the thread local property is removed ? Then that will be also an assertion as well?

[ShanChathusanda93]

No we cant because the thread local property will be added from a listener and the listeners are not executing when the test method is running.

[AnuradhaSK]

Yes specifically adding the property before test method is required,
but when executing the test method "private boolean isFragmentApp()" method should be invoked in this case and it should remove the thread local right?

Given that is the expectation, here we can validate that thread local property has been removed at the end

[ShanChathusanda93]

Assertion added to check whether the thread local property is cleared

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jenkins-is-staging]

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12367206077

[jenkins-is-staging]

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12367206077
Status: success

[jenkins-is-staging]

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12367206077