Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback to IDN_ACTION_PROPERTIES table #6578

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

osandamaleesha
Copy link
Contributor

@osandamaleesha osandamaleesha commented Mar 3, 2025

Proposed changes in this pull request

This PR adds the backward compatibilty in BE to support the future schema change to be done in IDN_ACTION_PROPERTIES table. When the PROPERTY_VALUE column is getting changed to PRIMITIVE_VALUE column this BE logic handles the CRUD operations.

When should this PR be merged

Soon

Follow up actions

  • Todo code lines mentioned in this implementation should be removed with a new PR after the new schema change becomes stable in the PROD

Related issue

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 73.07692% with 14 lines in your changes missing coverage. Please review.

Project coverage is 47.12%. Comparing base (e08010e) to head (90cb2b3).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
...ent/internal/dao/impl/ActionManagementDAOImpl.java 73.07% 8 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6578      +/-   ##
============================================
- Coverage     47.15%   47.12%   -0.03%     
+ Complexity    15561    15504      -57     
============================================
  Files          1779     1779              
  Lines        106913   107030     +117     
  Branches      20201    20222      +21     
============================================
+ Hits          50411    50440      +29     
- Misses        49427    49502      +75     
- Partials       7075     7088      +13     
Flag Coverage Δ
unit 31.02% <73.07%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13641504204

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13641504204
Status: failure

Copy link

sonarqubecloud bot commented Mar 4, 2025

@osandamaleesha
Copy link
Contributor Author

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/13641504204 Status: failure

Integration test failures are intermittent and not relevant to the changes

@ashanthamara ashanthamara merged commit 4b62fe9 into wso2:master Mar 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants