Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delete option from default claims and dialects #7069

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

amanda-ariyaratne
Copy link
Contributor

Purpose

With the in-memory claim management feature, the default set of claim dialects and claims cannot be deleted. This PR, therefore, removes the delete option from the UI.

Local Claims Before

Screenshot 2024-10-31 at 10 17 02

Local Claims After

Screenshot 2024-10-31 at 10 17 27

External Claims Before

Screenshot 2024-10-31 at 10 24 22

External Claims After

Screenshot 2024-10-31 at 10 25 49

Related PRs

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.79%. Comparing base (ccff022) to head (2b32068).
Report is 1103 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7069   +/-   ##
=======================================
  Coverage   31.79%   31.79%           
=======================================
  Files          41       41           
  Lines         890      890           
  Branches      220      204   -16     
=======================================
  Hits          283      283           
- Misses        557      607   +50     
+ Partials       50        0   -50     
Flag Coverage Δ
@wso2is/core 31.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

---- 🚨 Try these New Features:

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@amanda-ariyaratne amanda-ariyaratne merged commit 056ebc9 into wso2:master Nov 20, 2024
11 checks passed
@amanda-ariyaratne amanda-ariyaratne mentioned this pull request Nov 20, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants