-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display authorization details in authentication web application #7117
base: master
Are you sure you want to change the base?
Conversation
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
@@ -192,6 +192,7 @@ under.construction=This page is under construction | |||
by.selecting.following.attributes=By selecting the following attributes you agree to share them with | |||
select.all=Select All | |||
requested.scopes=Obtain permission for | |||
requested.authorization-details=Gain consent for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's follow the convention for i18n keys.
Also update the other language properties files too.
requested.authorization-details=Gain consent for | |
requested.authorization.details=Gain consent for |
<i aria-hidden="true" class="circle tiny icon primary consent-item-bullet" id="Authorization Details Types"></i> | ||
<div class="content mt-2"> | ||
<div class="header light-font"> | ||
<%=AuthenticationEndpointUtil.i18n(resourceBundle, "requested.authorization-details")%> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the i18n function defined in identity-apps-core/apps/authentication-portal/src/main/webapp/includes/localize.jsp instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7117 +/- ##
=======================================
Coverage 32.02% 32.02%
=======================================
Files 41 41
Lines 893 893
Branches 220 220
=======================================
Hits 286 286
+ Misses 607 557 -50
- Partials 0 50 +50
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes in this pull request
This PR introduces support for displaying authorization details in the authentication web application, specifically enhancing user interaction as per the Rich Authorization Requests (RFC9396) specification.
oauth2_authz.jsp
andoauth2_consent.jsp
files.Related Issues
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation