Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getRoleBasicInfoById when checking Administrator role #7131

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SujanSanjula96
Copy link
Contributor

Purpose

Use getRoleBasicInfoById instead of getRole method when checking Administrator role to avoid unnecessary DB calls.

Related Issues

wso2/product-is#21496

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.02%. Comparing base (a452c28) to head (2caad4d).
Report is 176 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7131   +/-   ##
=======================================
  Coverage   32.02%   32.02%           
=======================================
  Files          41       41           
  Lines         893      893           
  Branches      220      216    -4     
=======================================
  Hits          286      286           
  Misses        557      557           
  Partials       50       50           
Flag Coverage Δ
@wso2is/core 32.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11929101696

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11929101696
Status: failure

@pavinduLakshan
Copy link
Contributor

PR builder completed Link: wso2/product-is/actions/runs/11929101696 Status: failure

PR builder is not working for identity-apps PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants