Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show pagination issue in roles page #7193

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

mpmadhavig
Copy link
Contributor

Set showPagination prop to true, as the previous logic causes the pagination element to reset when the next button is clicked for the first time as the roleList value being null sometimes.

Related Issues:

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.02%. Comparing base (a085064) to head (269041c).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7193   +/-   ##
=======================================
  Coverage   32.02%   32.02%           
=======================================
  Files          41       41           
  Lines         893      893           
  Branches      204      220   +16     
=======================================
  Hits          286      286           
+ Misses        607      587   -20     
- Partials        0       20   +20     
Flag Coverage Δ
@wso2is/core 32.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@pavinduLakshan
Copy link
Contributor

Let's add changeset

pavinduLakshan
pavinduLakshan previously approved these changes Dec 10, 2024
@pavinduLakshan pavinduLakshan dismissed their stale review December 10, 2024 09:56

missing changeset

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@mpmadhavig mpmadhavig merged commit 192dc56 into wso2:master Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants