Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Admin Advisory" and "Remote Log Publishing" cards from Server section #7217

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

ThaminduDilshan
Copy link
Contributor

@ThaminduDilshan ThaminduDilshan commented Dec 18, 2024

Purpose

Admin Advisory Banner and Remote Log Publishing sections are moved to Manage Root Organization > Configure System Settings under the tenant picker with the multi tenancy onboarding effort. This PR removes these two cards from the server section.

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.32%. Comparing base (6fea1c7) to head (a7f0bc5).
Report is 30 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7217   +/-   ##
=======================================
  Coverage   32.32%   32.32%           
=======================================
  Files          42       42           
  Lines         897      897           
  Branches      221      204   -17     
=======================================
  Hits          290      290           
  Misses        607      607           
Flag Coverage Δ
@wso2is/core 32.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pavinduLakshan
Copy link
Contributor

pavinduLakshan commented Dec 18, 2024

@ThaminduDilshan afair, there was another card called "Manage notification handling" in the server page. With this improvement, server page will only have that card, won't it?

PS: Had an offline discussion with @brionmario and concluded that we need to move that notification handling card to Login and Registration. Let's link the relevant issue for that improvement as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect to Empty Page on "Admin Advisory" and "Remote Log Publishing" in Server Section
3 participants