Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to modify the primary user store domain name in console and myaccount apps #7239

Merged
merged 11 commits into from
Jan 7, 2025

Conversation

DilshanSenarath
Copy link
Contributor

@DilshanSenarath DilshanSenarath commented Jan 1, 2025

Purpose

This PR updates instances where the primary user store domain name was hardcoded on the frontend. With this change, users will be able to modify the primary user store domain name and use the console with the new configuration.

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.04%. Comparing base (4f2a110) to head (5c00cc1).
Report is 167 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7239      +/-   ##
==========================================
+ Coverage   32.32%   36.04%   +3.71%     
==========================================
  Files          42       42              
  Lines         897      899       +2     
  Branches      216      205      -11     
==========================================
+ Hits          290      324      +34     
- Misses        557      575      +18     
+ Partials       50        0      -50     
Flag Coverage Δ
@wso2is/core 36.04% <100.00%> (+3.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
modules/core/src/constants/userstore-constants.ts 80.00% <ø> (-3.34%) ⬇️
modules/core/src/helpers/profile.ts 87.23% <100.00%> (+69.84%) ⬆️
modules/core/src/utils/string-utils.ts 25.71% <100.00%> (+4.50%) ⬆️

... and 13 files with indirect coverage changes

@DilshanSenarath DilshanSenarath changed the title Add the option to modify the primary user store domain name in console app Add the option to modify the primary user store domain name in console and myaccount apps Jan 2, 2025
apps/myaccount/src/configs/app.ts Outdated Show resolved Hide resolved
apps/myaccount/src/configs/app.ts Show resolved Hide resolved
modules/core/src/helpers/profile.ts Show resolved Hide resolved
modules/core/src/utils/__tests__/string-utils.test.ts Outdated Show resolved Hide resolved
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@DilshanSenarath DilshanSenarath merged commit 8d5087f into wso2:master Jan 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants