feat: log missing translation instead of panic

wtlin1228 · Oct 11, 2024 · 06cc895 · 06cc895
1 parent 735ee2c
commit 06cc895
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 16 deletions.
diff --git a/crates/cli/src/main.rs b/crates/cli/src/main.rs
@@ -553,14 +553,18 @@ impl Project {
                     symbol_name,
                 ))?;
             for key in i18n_keys.iter() {
-                let translation =
-                    self.project
-                        .get_translation(&self.db.conn, key)
-                        .context(format!(
-                        "try to add translation for symbol {}, but translation {} doesn't exist",
-                        symbol_name, key
-                    ))?;
-                models::TranslationUsage::create(&self.db.conn, &translation, &symbol)?;
+                match self.project.get_translation(&self.db.conn, key) {
+                    Ok(translation) => {
+                        models::TranslationUsage::create(&self.db.conn, &translation, &symbol)
+                            .context(format!(
+                                "relate symbol {} to translation {}",
+                                symbol_name, key
+                            ))?;
+                    }
+                    Err(_) => {
+                        println!("try to add translation for symbol {}, but translation {} doesn't exist", symbol_name, key);
+                    }
+                }
             }
         }
         Ok(())

diff --git a/web/src/search/components/TreeView.tsx b/web/src/search/components/TreeView.tsx
@@ -23,13 +23,15 @@ const StyledTreeView = styled(SimpleTreeView)({
 });
 
 const mapAllModuleSymbolToString = (
-  project_root: string,
   tracePaths: ModuleSymbol[][]
 ): string[][] => {
   return tracePaths.map((tracePath) =>
     tracePath.map(({ module_path, symbol_name }) => {
-      let shorterPath = module_path.slice(project_root.length);
-      return `${symbol_name}@${shorterPath}`;
+      if (module_path.startsWith("/")) {
+        return `${symbol_name}@${module_path.slice(1)}`;
+      } else {
+        return `${symbol_name}@${module_path}`;
+      }
     })
   );
 };
@@ -86,7 +88,7 @@ export const TreeView = React.memo(function TreeView({
   return (
     <Box
       sx={{
-        "overflow-x": "scroll",
+        overflowX: "scroll",
         pb: 2,
       }}
     >
@@ -103,10 +105,7 @@ export const TreeView = React.memo(function TreeView({
                   {Object.entries(traceTargets).map(([traceTarget, paths]) => (
                     <TracePathToTreeView
                       key={`${i18nKey} - ${url} - ${traceTarget}`}
-                      tracePaths={mapAllModuleSymbolToString(
-                        data.project_root,
-                        paths
-                      )}
+                      tracePaths={mapAllModuleSymbolToString(paths)}
                     />
                   ))}
                 </TreeItem>