feat(cli): add support for reading schema from stdin in subgraph check command #1512
+31
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L42y
force-pushed
the
feat/wgc-subgraph-check-from-stdin
branch
from
58f14fa to
35b9825
Compare
StarpTech
requested changes
Jan 16, 2025
| @@ -50,8 +47,27 @@ export default (opts: BaseCommandOptions) => { | |||
| }); | |||
| } | |||
|
|
|||
| // submit an empty schema in case of a delete check | |||
| const schema = schemaFile ? await readFile(schemaFile) : Buffer.from(''); | |||
| // Handle schema input | |||
There was a problem hiding this comment.
@L42y the apollo approach in accepting the schema from stdin is unusual. Why should we use the --schema flag when piping data is already implicit? Additionally, --schema is declared as a way to specify a file path.
What do you think about this approach?
data | wgc subgraph check my-graph
This would follow the behaviour of common unix tools. An example to implement this is demonstrated here. This can be then also reused across all other commands.
There was a problem hiding this comment.
Let me know what you think, I think both approaches has it's benefits.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I want to introspect the schema then pipe to wgc for subgraph check without saving it to actual file first, as demonstrated in Apollo's Rover: https://www.apollographql.com/docs/rover/commands/subgraphs#subgraph-check
Checklist