This repository has been archived by the owner on Aug 2, 2019. It is now read-only.
Do not raise exception if eric binaries are not available #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryszard
reviewed
Mar 20, 2018
lib/liberic/sdk/api.rb
Outdated
| def self.attach_eric_function(name, params, return_type, original_name = nil) | ||
| define_method(name) { |*options| true } | ||
| end | ||
| extend self |
There was a problem hiding this comment.
Just to understand - why you need to extend self?
There was a problem hiding this comment.
It defines an instance method in the receiver https://apidock.com/ruby/Module/define_method
Here we are using Module so the "extend self" keeps the instance methods public.
Anyway I changed this code. Now I will use define_singleton_method that doesn't require "extend self"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.