Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate domain to midea_lan #159

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

chemelli74
Copy link
Collaborator

Migrate domain to midea_lan as current integration doesn't handle only AC devices.

Is a breaking change because users will not be able to downgrade smoothly after that change.
In case is needed, the only way will be to remove all devices, downgrade and then readd them back.

Needs #158 (to separate duties)

@chemelli74 chemelli74 added the breaking change A change that is not backwards compatible label Jun 23, 2024
Copy link

@raman325 raman325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

integration folder needs to be renamed to match new domain name

@wuwentao
Copy link
Owner

integration folder needs to be renamed to match new domain name

integration folder needs to be renamed to match new domain name

Thank you very much for your review and help,
it should available in this PR: #86

@chimilli74 may want to do some changes or keep curent mode, maybe need to check later.

in addition, PR is welcome to help us with this HA integration.

@chemelli74
Copy link
Collaborator Author

integration folder needs to be renamed to match new domain name

Indeed, is a draft as I want to merge first #158 and then rebase only once

@chemelli74 chemelli74 force-pushed the chemelli74-migrate-domain branch from 64318ad to 9f25519 Compare June 24, 2024 12:09
@chemelli74 chemelli74 marked this pull request as ready for review June 24, 2024 15:36
@chemelli74 chemelli74 force-pushed the chemelli74-migrate-domain branch 3 times, most recently from 7a661a5 to e6c3283 Compare June 25, 2024 09:25
@chemelli74
Copy link
Collaborator Author

@wuwentao, thx so much for your debugging. Here the corresponding PR: home-assistant/brands#5616

@chemelli74 chemelli74 force-pushed the chemelli74-migrate-domain branch from d7635c3 to b9f2022 Compare June 27, 2024 07:53
@chemelli74 chemelli74 marked this pull request as ready for review June 27, 2024 07:53
@chemelli74 chemelli74 marked this pull request as draft July 2, 2024 11:08
@chemelli74
Copy link
Collaborator Author

Brands PR is now merged: home-assistant/brands#5616

@rreynier
Copy link

rreynier commented Aug 6, 2024

Curious when this will be merged? Holding off installing this until the rename is completed to avoid dealing with any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change that is not backwards compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants