-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate domain to midea_lan #159
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integration folder needs to be renamed to match new domain name
Thank you very much for your review and help, @chimilli74 may want to do some changes or keep curent mode, maybe need to check later. in addition, PR is welcome to help us with this HA integration. |
Indeed, is a draft as I want to merge first #158 and then rebase only once |
64318ad
to
9f25519
Compare
7a661a5
to
e6c3283
Compare
@wuwentao, thx so much for your debugging. Here the corresponding PR: home-assistant/brands#5616 |
d7635c3
to
b9f2022
Compare
Brands PR is now merged: home-assistant/brands#5616 |
Curious when this will be merged? Holding off installing this until the rename is completed to avoid dealing with any issues. |
Migrate domain to
midea_lan
as current integration doesn't handle only AC devices.Is a breaking change because users will not be able to downgrade smoothly after that change.
In case is needed, the only way will be to remove all devices, downgrade and then readd them back.
Needs #158 (to separate duties)