Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: main feature entity name #259

Merged
merged 3 commits into from
Jul 30, 2024
Merged

fix: main feature entity name #259

merged 3 commits into from
Jul 30, 2024

Conversation

caibinqing
Copy link
Collaborator

PR Description

  • Fix the naming of a device main feature, use "has_entity_name": True and "name": None
  • Add some entity name to 40 device

Reason & Detail

The previous implementation had some problems.

Related issue

#174

@rokam rokam merged commit 2a663fb into wuwentao:master Jul 30, 2024
10 checks passed
@caibinqing caibinqing deleted the entity-name branch July 30, 2024 16:15
@caibinqing caibinqing mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemelli74 chemelli74 chemelli74 left review comments

@rokam rokam rokam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caibinqing @rokam @chemelli74