-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add MideaACFreshAirFan feature turn_on and turn_off #285
Conversation
@elcajon for current PR lint checking, we still keep both python 3.11 for old HA version: as user may not upgrade to the latest verion and continue using old HA version. |
Sure, always willing to help in my spare time :) |
it can't works in HA 2024.3.3(with python 3.11) ************* Module midea_ac_lan.fan
custom_components/midea_ac_lan/fan.py:67:5: E1101: Class 'FanEntityFeature' has no 'TURN_ON' member (no-member)
custom_components/midea_ac_lan/fan.py:67:32: E1101: Class 'FanEntityFeature' has no 'TURN_OFF' member (no-member) it will read FAN_FEATURE_TURN_ON_OFF: FanEntityFeature = (
(FanEntityFeature.TURN_ON | FanEntityFeature.TURN_OFF)
if (MAJOR_VERSION, MINOR_VERSION) >= (2024, 8)
else FanEntityFeature(0)
) maybe we can refer to this changes:
|
Already added version check (line 3), it actually doesn't have any problems, but mypy doesn't know. Maybe could use |
PR Description
SSIA
https://developers.home-assistant.io/blog/2024/07/19/fan-fanentityfeatures-turn-on_off/
Reason & Detail
from the current HA (2024.8.2) logs
Related issue
none