-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AC): support current_humidity
for AC device climate
#411
feat(AC): support current_humidity
for AC device climate
#411
Conversation
I'm not sure is it enough to work like in the screenshot, but I could make additional changes if needed. |
thank you very much for your PR. this |
Sure! Is it ok now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, you can't add this property to base class MideaClimate
.
you can add it to class MideaACClimate(MideaClimate)
as it will works for AC device.
the reason:
as base class will be call for all the climate device, but only AC device support indoor_humidity
, for example, like FB/C3/CC/CF device, these device don't have attribute indoor_humidity
, so we can't add it in base class.
just add it in the same file, but move it under class name class MideaACClimate(MideaClimate)
Thanks
it's not the expected result.
current code still in line 160 in base class |
No problem, I moved it from base class. |
current_humidity
for climate
current_humidity
for climate
current_humidity
for climate
current_humidity
for AC device climate
thanks, approved and merged. |
PR Description
Support
current_humidity
forclimate