Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graphs on new architecture with interop layer #1007

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MaxToyberman
Copy link

No description provided.

@NikldjOne
Copy link

BarChart don't working, LineChart work

@NikldjOne
Copy link

NikldjOne commented Dec 28, 2024

added in node_modules/react-native-charts-wrapper/ios/ReactNativeCharts/bar/RNBarChartView.swift

   override func layoutSubviews() {
        super.layoutSubviews()
        _chart.frame = self.bounds // Adjust the chart's frame to fill the entire component's bounds
    }

It's work for me, for BarChart

@HasanElfalt
Copy link

HasanElfalt commented Dec 30, 2024

we need to add these lines to each chart kind (Line, bar, pie... etc)
I am using this Repo for the Line and Pie chart, and after adding these lines to the line and pie chart, it works well

override func layoutSubviews() {
        super.layoutSubviews()
        _chart.frame = self.bounds // Adjust the chart's frame to fill the entire component's bounds
}

@longprao
Copy link

Can someone merge this please? confirmed this PR works with the latest RN and Expo

@urvish-procare
Copy link

This is just for iOS. we are facing issue of Warning: TypeError: Cannot read property 'bubblingEventTypes' of null in Android. so do you have any idea on it. @MaxToyberman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants