Skip to content

Commit

Permalink
add todo for 404 for wrong ID
Browse files Browse the repository at this point in the history
  • Loading branch information
wvanhed authored Feb 6, 2024
1 parent 77a2b04 commit 17c1a8e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/mijnbib/mijnbibliotheek.py
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ def _open_account_loans_page(self, acc_url: str) -> str:
except mechanize.HTTPError as e:
if e.code == 500:
# duh, server crashes on incorrect or nonexisting ID in the link
# TODO: looks like nonexisting id has been changed to 404. Update logic
raise ItemAccessError(
"Loans url can not be opened. Likely incorrect or "
f"nonexisting account ID in the url '{acc_url}'"
Expand Down

0 comments on commit 17c1a8e

Please sign in to comment.