Clean up todos

src/mijnbib/__init__.py

@@ -11,4 +11,5 @@
     IncompatibleSourceError,
     ItemAccessError,
     PluginError,
+    TemporarySiteError,
 )

src/mijnbib/mijnbibliotheek.py

@@ -29,6 +29,7 @@
     IncompatibleSourceError,
     InvalidExtendLoanURL,
     ItemAccessError,
+    TemporarySiteError,
 )
 
 _log = logging.getLogger(__name__)
@@ -75,6 +76,7 @@ def get_loans(self, account_id: str) -> list[Loan]:
             AuthenticationError
             IncompatibleSourceError
             ItemAccessError: something went wrong fetching loans
+            TemporarySiteError
         """
         if not self._logged_in:
             self.login()
@@ -83,6 +85,8 @@ def get_loans(self, account_id: str) -> list[Loan]:
         html_string = self._open_account_loans_page(url)
         try:
             loans = LoansListPageParser(html_string, self.BASE_URL, account_id).parse()
+        except TemporarySiteError as e:
+            raise e
         except Exception as e:
             raise IncompatibleSourceError(
                 f"Problem scraping loans ({str(e)})", html_body=""
@@ -188,7 +192,7 @@ def extend_loans(self, extend_url: str, execute: bool = False) -> tuple[bool, di
             InvalidExtendLoanURL
             ExtendLoanError
         """
-        # TODO: would make more sense to return loan list (since final page is loan page)
+        # NOTE: would make more sense to return loan list (since final page is loan page)
         # Perhaps retrieving those loans again, and check extendability would also be good idea.
         if not self._logged_in:
             self.login()

src/mijnbib/parsers.py

@@ -9,6 +9,7 @@
 from bs4 import BeautifulSoup
 
 from mijnbib.models import Account, Loan, Reservation
+from mijnbib.plugin_errors import TemporarySiteError
 
 _log = logging.getLogger(__name__)
 
@@ -110,10 +111,12 @@ def parse(self) -> list[Loan]:
             )
             # Sometimes, this error is present
             if soup.find(string=re.compile(error_msg)) is not None:
-                # TODO: probably better to thrown an exception instead
-                _log.warning(
+                raise TemporarySiteError(
                     f"Loans or reservations can not be retrieved. Site reports: {error_msg}"
                 )
+                # _log.warning(
+                #     f"Loans or reservations can not be retrieved. Site reports: {error_msg}"
+                # )
             return loans
 
         # Unfortunately, the branch names are interwoven siblings of the loans,

src/mijnbib/plugin_errors.py

@@ -52,3 +52,7 @@ def __init__(self, msg, html_body: str):
 
 class ExtendLoanError(PluginError):
     """Raised when extending loan(s) failed for unclear reasons."""
+
+
+class TemporarySiteError(PluginError):
+    """Raised when the site reports a temporary error."""

tests/test_mijnbib.py

@@ -15,6 +15,7 @@ def test_mijnbib_available_imports():
             "ExtendLoanError",
             "IncompatibleSourceError",
             "PluginError",
+            "TemporarySiteError",
             "plugin_errors",
             "mijnbibliotheek",
             "parsers",