Raise tempsiteerror at login when 5xx

wvanhed · Feb 12, 2024 · 8bcf0c5 · 8bcf0c5
1 parent a27b007
commit 8bcf0c5
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/changelog.md b/changelog.md
@@ -2,6 +2,10 @@
 
 new: new feature /  impr: improvement /  fix: bug fix
 
+## v0.5.3 - WIP
+
+- impr: error handling during login now can raise TemporarySiteError
+
 ## v0.5.2 - 2024-02-11
 
 - impr: error handling for non-existing account id

diff --git a/src/mijnbib/login_handlers.py b/src/mijnbib/login_handlers.py
@@ -14,6 +14,7 @@
     AuthenticationError,
     CanNotConnectError,
     IncompatibleSourceError,
+    TemporarySiteError,
 )
 
 _log = logging.getLogger(__name__)
@@ -113,6 +114,10 @@ def _log_in(self):
         _log.debug(f"login (1) oauth_callback_url: {oauth_callback_url}")
         _log.debug(f"login (1) oauth_token       : {oauth_token}")
         _log.debug(f"login (1) hint              : {hint}")
+        if response.status_code >= 500:  # we've observed 500, 502 and 503:
+            raise TemporarySiteError(
+                f"Expected status code 302 during log in. Got '{response.status_code}'"
+            )
         if response.status_code != 302:
             raise IncompatibleSourceError(
                 f"Expected status code 302 during log in. Got '{response.status_code}'",

diff --git a/src/mijnbib/mijnbibliotheek.py b/src/mijnbib/mijnbibliotheek.py
@@ -81,6 +81,7 @@ def login(self) -> None:
             AuthenticationError
             CanNotConnectError
             IncompatibleSourceError
+            TemporarySiteError
         """
         url = (
             self.BASE_URL